jamesfredley commented on code in PR #86:
URL: https://github.com/apache/grails-forge-ui/pull/86#discussion_r2868980736
##########
app/launch/src/components/CodePreview/CodePreview.jsx:
##########
Review Comment:
Not something changed in this PR, but an exist bug
```js
while (contents && typeof match !== 'string' && parts.length) {
```
`match` is never defined. This should be `typeof contents !== 'string'`. The
loop still terminates because `parts.length` eventually hits 0, but the middle
condition is dead code (always true). This means the loop doesn't short-circuit
when it finds the file contents early - it keeps drilling into undefined
children.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
