jamesfredley commented on code in PR #86:
URL: https://github.com/apache/grails-forge-ui/pull/86#discussion_r2868982111
##########
app/launch/src/components/FeatureSelector/FeatureAvailable.jsx:
##########
@@ -11,26 +15,36 @@ const FeatureAvailable = ({ feature, toggleFeatures }) => {
className={`mn-feature-selection hoverable ${
feature.selected && 'selected'
Review Comment:
`${feature.selected && 'selected'}` renders "false" as CSS class
`app/launch/src/components/FeatureSelector/FeatureAvailable.jsx:16`
```jsx
className={`mn-feature-selection hoverable ${feature.selected &&
'selected'}`}
```
When `feature.selected` is falsy, `false && 'selected'` evaluates to
`false`, and template literals coerce that to the string `"false"`. Every
unselected card gets `class="mn-feature-selection hoverable false"`. Should be:
```jsx
className={`mn-feature-selection hoverable ${feature.selected ? 'selected' :
''}`}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
