jamesfredley commented on PR #86: URL: https://github.com/apache/grails-forge-ui/pull/86#issuecomment-3979905060
The ESLint config doesn't include Vitest/Jest globals (`describe`, `it`, `expect`), and there are pre-existing issues: - `app/launch/src/helpers/Cache.js:31,50` - two empty catch blocks - `app/launch/src/hooks/useMicronautSdk.js:15` - unused `apiUrl` variable - `app/launch/src/utility.js:112` - unused `reject` parameter The lint config should add Vitest globals support, and `.eslintrc.js` should also lint `*.jsx` files (currently the `lint` script only targets `*.js`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
