jamesfredley opened a new pull request, #87:
URL: https://github.com/apache/grails-forge-ui/pull/87
## Summary
Fixes bugs, lint errors, and build configuration issues identified during
review of #86.
### Bugs Fixed
- **`__dirname` undefined in ESM** (`vite.config.js:21`) - Compute via
`fileURLToPath(import.meta.url)` instead of relying on Vite's internal shim
- **`typeof match` undefined variable** (`CodePreview.jsx:146`) - `match`
was never defined; changed to `typeof contents !== 'string'` so the tree
traversal loop short-circuits correctly
- **`"false"` CSS class on unselected cards** (`FeatureAvailable.jsx:16`) -
`${feature.selected && 'selected'}` renders literal string `"false"`; use
ternary instead
- **Folder click shows "cannot be previewed"** (`CodePreview.jsx:184`) -
`handleFileSelection` now only fires for files and null-content entries,
letting folders expand/collapse normally
### Build & Lint Fixes
- **ESLint config overhauled** (`.eslintrc.js`) - Disable
`react/react-in-jsx-scope` (React 17 automatic JSX transform), disable
`react/prop-types` (not used), add jest env for test files, lint `*.jsx` files
- **All lint errors resolved** (212 -> 0) - Fix unused vars with `_` prefix,
fix import order, fix unescaped entities, wrap case-block declarations
- **Remove dead code** - `process.env: {}` Vite define shim (no
`process.env` references in src/), unused `ModalKeyboardHandler` import
### Other Improvements
- **Relative URLs in `index.html`** - Consistent with `base: './'` Vite
config
- **Remove duplicate manifest link** - Old CRA `manifest.json` leftover
- **Add `manualChunks`** - Split MUI into separate vendor chunk (357KB)
### Verification
| Check | Result |
|-------|--------|
| `npm run build` | Pass |
| `npm test` | 30/30 pass |
| `npm run lint` | 0 errors |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
