jamesfredley commented on code in PR #87:
URL: https://github.com/apache/grails-forge-ui/pull/87#discussion_r2869341560
##########
app/launch/index.html:
##########
@@ -4,13 +4,13 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
- <link rel="stylesheet" href="/css/material-icons.css">
+ <link rel="stylesheet" href="./css/material-icons.css">
Review Comment:
You're right - the codebase consistently uses absolute paths. Reverted in
1be9e0e. Also updated base in vite.config.js from './' to '/' to match.
##########
app/launch/index.html:
##########
@@ -23,7 +23,6 @@
<meta property='og:description' content='Grails is a powerful Groovy-based
web application framework for the JVM built on top of Spring Boot that has many
plugins to further extend its functionality.' />
<meta property='og:type' content='website' />
- <link rel="manifest" href="/manifest.json" />
Review Comment:
Good catch - it wasn't a duplicate in the original CRA index.html. What
happened: PR #86 replaced the old CRA manifest.json link with a new
site.webmanifest link (line 13), but also kept the old manifest.json link (line
27). So the duplicate was introduced by PR #86, not pre-existing. The
site.webmanifest link on line 13 is still present - only the stale
manifest.json reference was removed. PWA should be unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
