jdaugherty commented on code in PR #87:
URL: https://github.com/apache/grails-forge-ui/pull/87#discussion_r2869158802
##########
app/launch/index.html:
##########
@@ -4,13 +4,13 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
- <link rel="stylesheet" href="/css/material-icons.css">
+ <link rel="stylesheet" href="./css/material-icons.css">
Review Comment:
Isn't slash more accurate since the assets are hosted at the root?
##########
app/launch/index.html:
##########
@@ -23,7 +23,6 @@
<meta property='og:description' content='Grails is a powerful Groovy-based
web application framework for the JVM built on top of Spring Boot that has many
plugins to further extend its functionality.' />
<meta property='og:type' content='website' />
- <link rel="manifest" href="/manifest.json" />
Review Comment:
Isn't this required for PWA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
