xunliu commented on code in PR #3912:
URL: https://github.com/apache/gravitino/pull/3912#discussion_r1673871008
##########
catalogs/catalog-hadoop/src/test/java/com/datastrato/gravitino/catalog/hadoop/integration/test/HadoopCatalogIT.java:
##########
@@ -68,7 +68,7 @@ public class HadoopCatalogIT extends AbstractIT {
@BeforeAll
public static void setup() throws IOException {
- containerSuite.startHiveContainer();
+ containerSuite.startHiveContainer(false, ImmutableMap.of());
Review Comment:
Removed these code.
##########
dev/docker/hive/Dockerfile:
##########
@@ -22,7 +22,8 @@ LABEL maintainer="[email protected]"
ARG HADOOP_VERSION
ARG HIVE_VERSION
-ARG JDBC_DIVER_PACKAGE_NAME
Review Comment:
Currently, The `JDBC_DIVER_PACKAGE_NAME` argument unused, So we can delete
it.
##########
integration-test/src/test/java/com/datastrato/gravitino/integration/test/authorization/ranger/RangerDefines.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Copyright 2023 Datastrato Pvt Ltd.
Review Comment:
Done.
##########
docs/publish-docker-images.md:
##########
@@ -25,8 +25,9 @@ You can use GitHub actions to publish Docker images to the
Docker Hub repository
+ `datastrato/gravitino-ci-trino`.
+ Future plans include support for other data sources.
5. Input the `tag name`, for example: `0.1.0`, Then build and push the Docker
image name as `datastrato/{image-name}:0.1.0`.
-6. You must enter the correct `publish docker token` before you can execute
run `Publish Docker Image` workflow.
-7. Wait for the workflow to complete. You can see a new Docker image shown in
the [Datastrato Docker Hub](https://hub.docker.com/u/datastrato) repository.
+6. Input the `envoriments`, for example: `HADOOP_VERSION=3.1.0
HIVE_VERSION=3.1.3`, Then use special version to install HDFS and Hive.
Review Comment:
DONE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
