xunliu commented on code in PR #3912:
URL: https://github.com/apache/gravitino/pull/3912#discussion_r1683753572
##########
dev/docker/build-docker.sh:
##########
@@ -122,14 +134,18 @@ fi
cd ${script_dir}/${component_type}
if [[ "${platform_type}" == "all" ]]; then
if [ ${build_latest} -eq 1 ]; then
- docker buildx build --no-cache --pull --platform=linux/amd64,linux/arm64
${build_args} --push --progress plain -f Dockerfile -t ${image_name}:latest -t
${image_name}:${tag_name} .
+ # FIXME: need to add back --no-cache
Review Comment:
@unknowntpo Do we need to roll back the changed `--no-cache` in this PR?
##########
docs/publish-docker-images.md:
##########
@@ -25,8 +25,9 @@ You can use GitHub actions to publish Docker images to the
Docker Hub repository
+ `datastrato/gravitino-ci-trino`.
+ Future plans include support for other data sources.
5. Input the `tag name`, for example: `0.1.0`, Then build and push the Docker
image name as `datastrato/{image-name}:0.1.0`.
-6. You must enter the correct `publish docker token` before you can execute
run `Publish Docker Image` workflow.
-7. Wait for the workflow to complete. You can see a new Docker image shown in
the [Datastrato Docker Hub](https://hub.docker.com/u/datastrato) repository.
+6. Input the `environment`, for example: `HADOOP_VERSION=3.1.0
HIVE_VERSION=3.1.3`, Then use special version to install HDFS and Hive.
+7. You must enter the correct `publish docker token` before you can execute
run `Publish Docker Image` workflow.
+8. Wait for the workflow to complete. You can see a new Docker image shown in
the [Datastrato Docker Hub](https://hub.docker.com/u/datastrato) repository.
Review Comment:
@unknowntpo Please roll back these changed.
##########
dev/docker/hive/Dockerfile:
##########
@@ -97,54 +122,54 @@ RUN echo "HADOOP_CONF_DIR=${HADOOP_CONF_DIR}" >>
/etc/environment
RUN echo "HADOOP_CLASSPATH=${JAVA_HOME}/lib/tools.jar" >> /etc/environment
RUN echo "YARN_HOME=${YARN_HOME}" >> /etc/environment
RUN echo "HIVE_HOME=${HIVE_HOME}" >> /etc/environment
+RUN echo "ZK_HOME=${ZK_HOME}" >> /etc/environment
RUN echo "PATH=${PATH}" >> /etc/environment
RUN echo "CLASSPATH=${CLASSPATH}" >> /etc/environment
RUN echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH}" >> /etc/environment
################################################################################
-# install hadoop
-RUN mkdir ${HADOOP_HOME}
-ADD packages/hadoop-${HADOOP_VERSION}.tar.gz /opt/
-RUN ln -s /opt/hadoop-${HADOOP_VERSION}/* ${HADOOP_HOME}
-
-# replace configuration templates
-RUN rm -f ${HADOOP_CONF_DIR}/core-site.xml
-RUN rm -f ${HADOOP_CONF_DIR}/hadoop-env.sh
-RUN rm -f ${HADOOP_CONF_DIR}/hdfs-site.xml
-RUN rm -f ${HADOOP_CONF_DIR}/mapred-site.xml
-
-ADD core-site.xml ${HADOOP_CONF_DIR}/core-site.xml
-ADD hadoop-env.sh ${HADOOP_CONF_DIR}/hadoop-env.sh
-ADD hdfs-site.xml ${HADOOP_CONF_DIR}/hdfs-site.xml
-ADD mapred-site.xml ${HADOOP_CONF_DIR}/mapred-site.xml
-ADD check-status.sh /tmp/check-status.sh
+# install zookeeper
+ADD packages/zookeeper-${ZOOKEEPER_VERSION}.tar.gz /opt/
+RUN ln -s /opt/zookeeper-${ZOOKEEPER_VERSION} ${ZK_HOME}
+RUN mkdir $ZK_HOME/data
Review Comment:
@unknowntpo Please change to `${ZK_HOME}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
