xunliu commented on code in PR #3912:
URL: https://github.com/apache/gravitino/pull/3912#discussion_r1679535631
##########
dev/docker/hive/Dockerfile:
##########
@@ -139,9 +147,15 @@ ADD mapred-site.xml ${HADOOP_CONF_DIR}/mapred-site.xml
ADD check-status.sh /tmp/check-status.sh
################################################################################
-# install hive
-ADD packages/apache-hive-${HIVE_VERSION}-bin.tar.gz /opt/
-RUN ln -s /opt/apache-hive-${HIVE_VERSION}-bin ${HIVE_HOME}
+RUN mkdir -p ${HIVE_HOME}/lib
Review Comment:
I think we didn't need to prepare to create `${HIVE_HOME}/lib` directory.
We only move `RUN ln -s
/opt/mysql-connector-java-${MYSQL_JDBC_DRIVER_VERSION}/* ${HIVE_HOME}/lib` to
`startup.sh`
##########
dev/docker/hive/start.sh:
##########
@@ -18,6 +18,18 @@
# under the License.
#
+echo "before link"
+ls -la ${HIVE_HOME}
+
+if [[ "${ENABLE_RANGER_PLUGIN}" == "true" ]]; then
Review Comment:
I think we need a new environment `HIVE_VERSION`.
```
if [[ "${HIVE_VERSION}" == "hive3" ]]; then
```
##########
dev/docker/hive/Dockerfile:
##########
@@ -181,6 +195,9 @@ RUN chown -R datastrato:hadoop /home/datastrato
RUN rm -rf /tmp/packages
RUN rm -rf /var/lib/apt/lists/*
+RUN touch ${HIVE_HOME}/conf/orig.txt
+RUN touch ${HIVE_HOME}/lib/orig.txt
Review Comment:
Why do we need to add these codes? is a temporary test code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
