xunliu commented on code in PR #3912:
URL: https://github.com/apache/gravitino/pull/3912#discussion_r1683851651
##########
docs/publish-docker-images.md:
##########
@@ -25,8 +25,6 @@ You can use GitHub actions to publish Docker images to the
Docker Hub repository
+ `datastrato/gravitino-ci-trino`.
+ Future plans include support for other data sources.
5. Input the `tag name`, for example: `0.1.0`, Then build and push the Docker
image name as `datastrato/{image-name}:0.1.0`.
-6. You must enter the correct `publish docker token` before you can execute
run `Publish Docker Image` workflow.
-7. Wait for the workflow to complete. You can see a new Docker image shown in
the [Datastrato Docker Hub](https://hub.docker.com/u/datastrato) repository.
Review Comment:
We didn't delete these two lines.
##########
dev/docker/build-docker.sh:
##########
@@ -87,7 +87,19 @@ fi
if [[ "${component_type}" == "hive" ]]; then
. ${script_dir}/hive/hive-dependency.sh
- build_args="--build-arg HADOOP_PACKAGE_NAME=${HADOOP_PACKAGE_NAME}
--build-arg HIVE_PACKAGE_NAME=${HIVE_PACKAGE_NAME} --build-arg
JDBC_DIVER_PACKAGE_NAME=${JDBC_DIVER_PACKAGE_NAME} --build-arg
HADOOP_VERSION=${HADOOP_VERSION} --build-arg HIVE_VERSION=${HIVE_VERSION}
--build-arg MYSQL_JDBC_DRIVER_VERSION=${MYSQL_JDBC_DRIVER_VERSION}"
+ build_args="
+ --build-arg HADOOP_PACKAGE_NAME=${HADOOP_PACKAGE_NAME} \
+ --build-arg HIVE_PACKAGE_NAME=${HIVE_PACKAGE_NAME} \
+ --build-arg HADOOP_VERSION=${HADOOP_VERSION} \
+ --build-arg HIVE_VERSION=${HIVE_VERSION} \
+ --build-arg MYSQL_JDBC_DRIVER_VERSION=${MYSQL_JDBC_DRIVER_VERSION} \
+ --build-arg RANGER_VERSION=${RANGER_VERSION} \
+ --build-arg ZOOKEEPER_VERSION=${ZOOKEEPER_VERSION} \
+ --build-arg HIVE2_VERSION=${HIVE2_VERSION} \
+ --build-arg HIVE3_VERSION=${HIVE3_VERSION}
+ --build-arg HADOOP2_VERSION=${HADOOP2_VERSION}
Review Comment:
I think need to add `\` at the end of the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
