shaofengshi commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1773198517
##########
docs/manage-metalake-using-gravitino.md:
##########
@@ -136,9 +133,6 @@ GravitinoMetalake renamed =
gravitinoAdminClient.alterMetalake(
```python
changes = (
MetalakeChange.rename("metalake_new_name"),
- MetalakeChange.update_comment("metalake_new_comment"),
- MetalakeChange.remove_property("metalake_properties_key1"),
- MetalakeChange.set_property("metalake_properties_key2",
"metalake_properties_new_value"),
)
metalake = gravitino_admin_client.alter_metalake("metalake_name", *changes)
Review Comment:
To be consistent with the java example, here the metalake name should be
"metalake", what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
