jun-ma commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1774296728
##########
docs/manage-metalake-using-gravitino.md:
##########
@@ -107,15 +109,10 @@ curl -X PUT -H "Accept:
application/vnd.gravitino.v1+json" \
"updates": [
{
"@type": "rename",
- "newName": "metalake"
- },
- {
- "@type": "setProperty",
- "property": "key2",
- "value": "value2"
Review Comment:
@shaofengshi thanks for your review comments. Let me explain my intention a
bit more:
1. I agree that alteration implies multiple types of changes. However, the
original [Java
example](https://github.com/apache/gravitino/pull/4997/files#diff-6c143eb15fabcf14ab059a759f44c8c93dea1c8cf4c3f033d9cadb0809cd97e6R123)
only introduces the renaming case, which brings inconsistencies among
languages.
2. A [complete
table](https://github.com/apache/gravitino/pull/4997/files#diff-6c143eb15fabcf14ab059a759f44c8c93dea1c8cf4c3f033d9cadb0809cd97e6R145)
down below outlines the allowed changes, which would be more efficient for
users to get to know the whole picture of altering. Duplicating them in
examples is not necessary, because examples are intended to be as simple as
possible -- especially the altering scope may scale as Gravitino evolves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
