jun-ma commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1774303874
##########
docs/manage-metalake-using-gravitino.md:
##########
@@ -136,9 +133,6 @@ GravitinoMetalake renamed =
gravitinoAdminClient.alterMetalake(
```python
changes = (
MetalakeChange.rename("metalake_new_name"),
- MetalakeChange.update_comment("metalake_new_comment"),
- MetalakeChange.remove_property("metalake_properties_key1"),
- MetalakeChange.set_property("metalake_properties_key2",
"metalake_properties_new_value"),
)
metalake = gravitino_admin_client.alter_metalake("metalake_name", *changes)
Review Comment:
Yes, it would make more sense. I hesitated for a second and didn't change
the values of the Python examples because they all adopted a different naming
convention -- I'm afraid one minor update would bring more inconsistencies at
this moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
