yuqi1129 commented on code in PR #5209:
URL: https://github.com/apache/gravitino/pull/5209#discussion_r1812517100
##########
clients/client-python/gravitino/filesystem/gvfs.py:
##########
@@ -348,11 +356,17 @@ def rm(self, path, recursive=False, maxdepth=None):
)
actual_path = context_pair.actual_file_location()
storage_type = self._recognize_storage_type(actual_path)
- context_pair.filesystem().rm(
- self._strip_storage_protocol(storage_type, actual_path),
- recursive,
- maxdepth,
- )
+ fs = context_pair.filesystem()
+
+ # S3FileSystem doesn't support maxdepth
+ if isinstance(fs, self.lazy_load_class("s3fs", "S3FileSystem")):
Review Comment:
It actually not and the error will be:
```
======================================================================
ERROR: test_rm (test_gvfs_with_s3.TestGvfsWithS3)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/home/ec2-user/gravitino/clients/client-python/tests/integration/test_gvfs_with_s3.py",
line 195, in test_rm
fs.rm(rm_file)
File
"/home/ec2-user/gravitino/clients/client-python/gravitino/filesystem/gvfs.py",
line 355, in rm
context_pair.filesystem().rm(
File
"/home/ec2-user/gravitino/.gradle/python/Linux/Miniforge3/envs/python-3.8/lib/python3.8/site-packages/fsspec/asyn.py",
line 118, in wrapper
return sync(self.loop, func, *args, **kwargs)
File
"/home/ec2-user/gravitino/.gradle/python/Linux/Miniforge3/envs/python-3.8/lib/python3.8/site-packages/fsspec/asyn.py",
line 85, in sync
coro = func(*args, **kwargs)
TypeError: _rm() takes from 2 to 3 positional arguments but 4 were given
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
