xloya commented on code in PR #5209:
URL: https://github.com/apache/gravitino/pull/5209#discussion_r1812539447
##########
clients/client-python/gravitino/filesystem/gvfs.py:
##########
@@ -348,11 +356,17 @@ def rm(self, path, recursive=False, maxdepth=None):
)
actual_path = context_pair.actual_file_location()
storage_type = self._recognize_storage_type(actual_path)
- context_pair.filesystem().rm(
- self._strip_storage_protocol(storage_type, actual_path),
- recursive,
- maxdepth,
- )
+ fs = context_pair.filesystem()
+
+ # S3FileSystem doesn't support maxdepth
+ if isinstance(fs, self.lazy_load_class("s3fs", "S3FileSystem")):
Review Comment:
I see. I checked the s3fs code, it does not support max depth indeed:
https://github.com/fsspec/s3fs/blob/main/s3fs/core.py#L2001.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
