jerryshao commented on code in PR #5209:
URL: https://github.com/apache/gravitino/pull/5209#discussion_r1814182875
##########
clients/client-python/gravitino/filesystem/gvfs_config.py:
##########
@@ -32,6 +32,8 @@ class GVFSConfig:
OAUTH2_PATH = "oauth2_path"
OAUTH2_SCOPE = "oauth2_scope"
- GVFS_FILESYSTEM_BY_PASS = "gravitino.bypass"
- GVFS_FILESYSTEM_BY_PASS_GCS = "gravitino.bypass.gcs."
- GVFS_FILESYSTEM_KEY_FILE = "service-account-key-path"
+ GVFS_FILESYSTEM_GCS_SERVICE_KEY_FILE = "gcs_service_account_key_path"
+
+ GVFS_FILESYSTEM_S3_ACCESS_KEY = "s3_access_key"
+ GVFS_FILESYSTEM_S3_SECRET_KEY = "s3_secret_key"
+ GVFS_FILESYSTEM_S3_ENDPOINT = "s3_endpoint"
Review Comment:
I suggest that we should also redefine the Java side gvfs and Hadoop catalog
s3/oss/gcs related configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
