justinmclean commented on code in PR #5759:
URL: https://github.com/apache/gravitino/pull/5759#discussion_r1870613970
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java:
##########
@@ -33,6 +33,8 @@ public static void output(Object object) {
new MetalakesStringFormat().output((Metalake[]) object);
} else if (object instanceof Catalog) {
new CatalogStringFormat().output((Catalog) object);
+ } else if (object instanceof Catalog[]) {
+ new CatalogsStringFormat().output((Catalog[]) object);
Review Comment:
I wodl call them `CatalogStringFormat`, `CatalogPlainFormat` etc
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java:
##########
@@ -33,6 +33,8 @@ public static void output(Object object) {
new MetalakesStringFormat().output((Metalake[]) object);
} else if (object instanceof Catalog) {
new CatalogStringFormat().output((Catalog) object);
+ } else if (object instanceof Catalog[]) {
+ new CatalogsStringFormat().output((Catalog[]) object);
Review Comment:
I would call them `CatalogStringFormat`, `CatalogPlainFormat` etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
