justinmclean commented on code in PR #5759:
URL: https://github.com/apache/gravitino/pull/5759#discussion_r1872546746
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -201,7 +201,7 @@ private void handleCatalogCommand() {
String outputFormat = line.getOptionValue(GravitinoOptions.OUTPUT);
if (CommandActions.LIST.equals(command)) {
- newListCatalogs(url, ignore, metalake).handle();
+ newListCatalogs(url, ignore, metalake, outputFormat).handle();
Review Comment:
I would not pass the CommondOption in the function parameters, so the
command needs to know about the CLI library we use, and it makes it hard to
know what options a command uses. Currently, we only have one list option and
one delete option. I think we could change to a ListOptions or similar when
adding extra options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
