tengqm commented on code in PR #5759:
URL: https://github.com/apache/gravitino/pull/5759#discussion_r1872405397
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -201,7 +201,7 @@ private void handleCatalogCommand() {
String outputFormat = line.getOptionValue(GravitinoOptions.OUTPUT);
if (CommandActions.LIST.equals(command)) {
- newListCatalogs(url, ignore, metalake).handle();
+ newListCatalogs(url, ignore, metalake, outputFormat).handle();
Review Comment:
I'd suggest we come up with a ListOptions wrapper for this case.
In the foreseeable future, you may want to add filter, sorting, field
selector, paging options. The list of parameters to pass would grow and you
have to change all these places again and again. This process is tedious and
error prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
