diqiu50 commented on code in PR #5835: URL: https://github.com/apache/gravitino/pull/5835#discussion_r1881280540
########## clients/filesystem-fuse/src/filesystem.rs: ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use async_trait::async_trait; +use bytes::Bytes; +use fuse3::{Errno, FileType, Timestamp}; + +pub(crate) type Result<T> = std::result::Result<T, Errno>; + +/// RawFileSystem interface for the file system implementation. it use by FuseApiHandle +/// the `file_id` and `parent_file_id` it is the unique identifier for the file system, it is used to identify the file or directory +/// the `fh` it is the file handle, it is used to identify the opened file, it is used to read or write the file content +#[async_trait] +pub(crate) trait RawFileSystem: Send + Sync { + async fn init(&self); + + async fn get_file_path(&self, file_id: u64) -> String; Review Comment: The `inode id` is special for `inode`, the `file_id` is generally, it is can look like the `inode id` ########## clients/filesystem-fuse/src/filesystem.rs: ########## @@ -0,0 +1,205 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use async_trait::async_trait; +use bytes::Bytes; +use fuse3::{Errno, FileType, Timestamp}; + +pub(crate) type Result<T> = std::result::Result<T, Errno>; + +/// RawFileSystem interface for the file system implementation. it use by FuseApiHandle +/// the `file_id` and `parent_file_id` it is the unique identifier for the file system, it is used to identify the file or directory +/// the `fh` it is the file handle, it is used to identify the opened file, it is used to read or write the file content +#[async_trait] +pub(crate) trait RawFileSystem: Send + Sync { + async fn init(&self); + + async fn get_file_path(&self, file_id: u64) -> String; + + async fn valid_file_id(&self, file_id: u64, fh: u64) -> Result<()>; + + async fn stat(&self, file_id: u64) -> Result<FileStat>; + + async fn lookup(&self, parent_file_id: u64, name: &str) -> Result<FileStat>; + + async fn read_dir(&self, dir_file_id: u64) -> Result<Vec<FileStat>>; + + async fn open_file(&self, file_id: u64, flags: u32) -> Result<FileHandle>; + + async fn open_dir(&self, file_id: u64, flags: u32) -> Result<FileHandle>; + + async fn create_file(&self, parent_file_id: u64, name: &str, flags: u32) -> Result<FileHandle>; + + async fn create_dir(&self, parent_file_id: u64, name: &str) -> Result<FileHandle>; + + async fn set_attr(&self, file_id: u64, file_stat: &FileStat) -> Result<()>; + + async fn remove_file(&self, parent_file_id: u64, name: &str) -> Result<()>; + + async fn remove_dir(&self, parent_file_id: u64, name: &str) -> Result<()>; + + async fn close_file(&self, file_id: u64, fh: u64) -> Result<()>; + + async fn read(&self, file_id: u64, fh: u64, offset: u64, size: u32) -> Result<Bytes>; + + async fn write(&self, file_id: u64, fh: u64, offset: u64, data: &[u8]) -> Result<u32>; +} + +/// PathFileSystem is the interface for the file system implementation, it use to interact with other file system +/// it is used file name or path to operate the file system +#[async_trait] +pub(crate) trait PathFileSystem: Send + Sync { Review Comment: I will commit the usage in the next pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
