diqiu50 commented on code in PR #5835: URL: https://github.com/apache/gravitino/pull/5835#discussion_r1881904926
########## clients/filesystem-fuse/src/fuse_api_handle.rs: ########## @@ -0,0 +1,446 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +use crate::filesystem::{FileStat, FileSystemContext, RawFileSystem}; +use fuse3::path::prelude::{ReplyData, ReplyOpen, ReplyStatFs, ReplyWrite}; +use fuse3::path::Request; +use fuse3::raw::prelude::{ + FileAttr, ReplyAttr, ReplyCreated, ReplyDirectory, ReplyDirectoryPlus, ReplyEntry, ReplyInit, +}; +use fuse3::raw::reply::{DirectoryEntry, DirectoryEntryPlus}; +use fuse3::raw::Filesystem; +use fuse3::FileType::{Directory, RegularFile}; +use fuse3::{Errno, FileType, Inode, SetAttr, Timestamp}; +use futures_util::stream; +use futures_util::stream::BoxStream; +use futures_util::StreamExt; +use std::ffi::{OsStr, OsString}; +use std::num::NonZeroU32; +use std::time::{Duration, SystemTime}; + +pub(crate) struct FuseApiHandle<T: RawFileSystem> { + local_fs: T, + default_ttl: Duration, + fs_context: FileSystemContext, +} + +impl<T: RawFileSystem> FuseApiHandle<T> { + const DEFAULT_TTL: Duration = Duration::from_secs(1); + const DEFAULT_MAX_WRITE: u32 = 16 * 1024; + + pub fn new(fs: T, context: FileSystemContext) -> Self { + Self { + local_fs: fs, + default_ttl: Self::DEFAULT_TTL, + fs_context: context, + } + } + + pub async fn get_file_path(&self, file_id: u64) -> String { + self.local_fs.get_file_path(file_id).await + } + + async fn get_modified_file_stat( + &self, + file_id: u64, + size: Option<u64>, + atime: Option<Timestamp>, + mtime: Option<Timestamp>, + ) -> Result<FileStat, Errno> { + let mut file_stat = self.local_fs.stat(file_id).await?; + + if let Some(size) = size { + file_stat.size = size; + }; + + if let Some(atime) = atime { + file_stat.atime = atime; + }; + + if let Some(mtime) = mtime { + file_stat.mtime = mtime; + }; + + Ok(file_stat) + } +} + +impl<T: RawFileSystem> Filesystem for FuseApiHandle<T> { + async fn init(&self, _req: Request) -> fuse3::Result<ReplyInit> { + self.local_fs.init().await; + Ok(ReplyInit { + max_write: NonZeroU32::new(Self::DEFAULT_MAX_WRITE).unwrap(), + }) + } + + async fn destroy(&self, _req: Request) { + //TODO need to call the destroy method of the local_fs + } + + async fn lookup( + &self, + _req: Request, + parent: Inode, + name: &OsStr, + ) -> fuse3::Result<ReplyEntry> { + let name = name.to_string_lossy(); + let file_stat = self.local_fs.lookup(parent, &name).await?; + Ok(ReplyEntry { + ttl: self.default_ttl, + attr: fstat_to_file_attr(&file_stat, &self.fs_context), Review Comment: Both are fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
