fsalhi2 opened a new pull request, #5923:
URL: https://github.com/apache/gravitino/pull/5923

   <!--
   1. Title: [#<issue>] <type>(<scope>): <subject>
      Examples:
        - "[#123] feat(operator): support xxx"
        - "[#233] fix: check null before access result in xxx"
        - "[MINOR] refactor: fix typo in variable name"
        - "[MINOR] docs: fix typo in README"
        - "[#255] test: fix flaky test NameOfTheTest"
      Reference: https://www.conventionalcommits.org/en/v1.0.0/
   2. If the PR is unfinished, please mark this PR as draft.
   -->
   
   ### What changes were proposed in this pull request?
   
   Removed the systematic validations in Iceberg Config and modified the 
instantiation of the warehouse attribute and uri attribute in the 
IcebergCatalogWrapper to conform with the new possibility (REST).
   
   ### Why are the changes needed?
   
   The bug was blocking the creation of a rest catalog.
   
   Fix: [#5756](https://github.com/apache/gravitino/issues/5756)
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   ./gradlew build && compileDistribution && assembleDistribution + creation of 
the docker image there : https://hub.docker.com/r/fsalhi2/gravitino
   
   Started gravitino with such configs : 
   
   ```
   ### Gravitino General Settings
   
   gravitino.auxService.names = iceberg-rest
   gravitino.iceberg-rest.classpath = iceberg-rest-server/libs, 
iceberg-rest-server/conf
   
   ### HTTP Server
   
   gravitino.iceberg-rest.host = 0.0.0.0
   gravitino.iceberg-rest.httpPort = 9001
   
   ### Storage
   
   gravitino.iceberg-rest.io-impl = org.apache.iceberg.aws.s3.S3FileIO
   gravitino.iceberg-rest.s3-access-key-id = XXXXX
   gravitino.iceberg-rest.s3-secret-access-key = XXXXXX
   gravitino.iceberg-rest.s3-path-style-access = true
   gravitino.iceberg-rest.s3-endpoint = http://minio:9000/
   gravitino.iceberg-rest.s3-region = us-east-1
   
   ### JDBC
   
   gravitino.iceberg-rest.catalog-backend = jdbc
   gravitino.iceberg-rest.uri = jdbc:mysql://mysql:3306/
   gravitino.iceberg-rest.warehouse = s3://lake/catalog
   gravitino.iceberg-rest.jdbc.user = root
   gravitino.iceberg-rest.jdbc.password = XXXXXX
   gravitino.iceberg-rest.jdbc-driver = com.mysql.cj.jdbc.Driver
   ```
   
   Was able to create a catalog and start working on the scheme. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to