FANNG1 commented on code in PR #5923:
URL: https://github.com/apache/gravitino/pull/5923#discussion_r1893520747
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/ops/IcebergCatalogWrapper.java:
##########
@@ -82,9 +82,12 @@ public IcebergCatalogWrapper(IcebergConfig icebergConfig) {
this.catalogBackend =
IcebergCatalogBackend.valueOf(
icebergConfig.get(IcebergConfig.CATALOG_BACKEND).toUpperCase(Locale.ROOT));
- if (!IcebergCatalogBackend.MEMORY.equals(catalogBackend)) {
+ if (!IcebergCatalogBackend.MEMORY.equals(catalogBackend)
+ && !IcebergCatalogBackend.REST.equals(catalogBackend)) {
// check whether IcebergConfig.CATALOG_WAREHOUSE exists
icebergConfig.get(IcebergConfig.CATALOG_WAREHOUSE);
Review Comment:
Could you check whether `IcebergConfig.CATALOG_WAREHOUSE` exists in
icebergConfig? As the check function is removed.
```
.checkValue(StringUtils::isNotBlank, ConfigConstants.NOT_BLANK_ERROR_MSG)
```
##########
gradle.properties:
##########
@@ -20,18 +20,18 @@
org.gradle.parallel=true
Review Comment:
the changes in `gradle.properties` seems not related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
