tengqm commented on code in PR #5923:
URL: https://github.com/apache/gravitino/pull/5923#discussion_r1894589415
##########
catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogPropertiesMetadata.java:
##########
@@ -74,10 +74,11 @@ public class IcebergCatalogPropertiesMetadata extends
BaseCatalogPropertiesMetad
false /* reserved */),
stringRequiredPropertyEntry(
URI, "Iceberg catalog uri config", false /* immutable */,
false /* hidden */),
- stringRequiredPropertyEntry(
+ stringOptionalPropertyEntry(
WAREHOUSE,
"Iceberg catalog warehouse config",
false /* immutable */,
+ null, /* defaultValue */
Review Comment:
We could have prevented this kind of obvious errors if we apply a stricter
coding style.
Can you help also wrap line 76?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
