justinmclean commented on PR #5897: URL: https://github.com/apache/gravitino/pull/5897#issuecomment-2555957779
This is not making 100% sense to me. This a couple of things I think can be improved here: - The output of `bin/gcli.sh tag set --metalake demo_metalake` should be `Missing --name option.` - The hasEntity logic seems wrong, and I not sure what you are trying to check here. Could teh function have a better name? - In hasEntity I'm not sure why you are checking 3 parts of the name when all sorts of entities can be tagged. Also columns will have a four part name. - Allo there are hasCatalogName, hasTableName, etc methods which would be better to use, if they needed to be used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
