justinmclean commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1899229881
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/UntagEntity.java:
##########
@@ -91,24 +93,20 @@ public void handle() {
} catch (NoSuchCatalogException err) {
exitWithError(ErrorMessages.UNKNOWN_CATALOG);
} catch (NoSuchSchemaException err) {
- exitWithError(ErrorMessages.UNKNOWN_TABLE);
+ exitWithError(ErrorMessages.UNKNOWN_SCHEMA);
} catch (NoSuchTableException err) {
exitWithError(ErrorMessages.UNKNOWN_TABLE);
} catch (Exception exp) {
exitWithError(exp.getMessage());
}
- String all = String.join(",", removeTags);
-
- if (all.equals("")) {
- all = "nothing";
- }
-
- if (tags.length > 1) {
- System.out.println(
- entity + " removed tags " + String.join(",", tags) + " now tagged
with " + all);
- } else {
- System.out.println(entity + " removed tag " + tags[0].toString() + " now
tagged with " + all);
- }
+ System.out.println(
+ entity
+ + " removed tag(s): ["
+ + COMMA_JOINER.join(tags)
+ + "], now tagged with "
+ + "["
+ + COMMA_JOINER.join(removeTags)
+ + "]");
Review Comment:
This also needs to be consistent with the messages given when you add tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
