justinmclean commented on code in PR #5897:
URL: https://github.com/apache/gravitino/pull/5897#discussion_r1899229809
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -667,7 +667,16 @@ protected void handleTagCommand() {
if (propertySet != null && valueSet != null) {
newSetTagProperty(url, ignore, metalake, getOneTag(tags),
propertySet, valueSet).handle();
} else if (propertySet == null && valueSet == null) {
+ if (!name.hasName()) {
+ System.err.println(ErrorMessages.MISSING_NAME);
+ Main.exit(-1);
+ }
newTagEntity(url, ignore, metalake, name, tags).handle();
+ } else {
+ System.err.println(
+ "Command cannot be executed. The set command only supports
configuring tag properties or attaching "
+ + "tags to entity.");
+ Main.exit(-1);
Review Comment:
This is a bit long and not in the same style as other error messages. I'd
shorten it to "The set command only supports tag properties or attaching tags."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
