FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897718392
########## core/src/main/java/org/apache/gravitino/credential/CatalogCredentialManager.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.credential; + +import java.io.Closeable; +import java.io.IOException; +import java.util.Map; +import org.apache.gravitino.exceptions.NoSuchCredentialException; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Manage lifetime of the credential provider in one catalog, dispatch credential request to the + * corresponding credential provider. + */ +public class CatalogCredentialManager implements Closeable { + + private static final Logger LOG = LoggerFactory.getLogger(CatalogCredentialManager.class); + + private CredentialCacheManager<CredentialCacheKey> cacheManager; + + private final String catalogName; + private final Map<String, CredentialProvider> credentialProviders; + + public CatalogCredentialManager(String catalogName, Map<String, String> catalogProperties) { + this.catalogName = catalogName; + this.credentialProviders = CredentialUtils.loadCredentialProviders(catalogProperties); + this.cacheManager = new CredentialCacheManager(); + cacheManager.initialize(catalogProperties); + } + + public Credential getCredential(String credentialType, CredentialContext context) { + CredentialCacheKey credentialCacheKey = new CredentialCacheKey(credentialType, context); + return cacheManager.getCredential(credentialCacheKey, cacheKey -> getCredential(cacheKey)); + } + + @Override + public void close() { + credentialProviders + .values() + .forEach( + credentialProvider -> { + try { + credentialProvider.close(); + } catch (IOException e) { + LOG.warn( + "Close credential provider failed, catalog: {}, credential provider: {}", + catalogName, + credentialProvider.credentialType(), + e); + } + }); + } + + public Credential getCredential(CredentialCacheKey credentialCacheKey) { + String credentialType = credentialCacheKey.getCredentialType(); + CredentialContext context = credentialCacheKey.getCredentialContext(); + LOG.info("try get credential, credential type: {}, context: {}", credentialType, context); Review Comment: use debug? ########## core/src/main/java/org/apache/gravitino/credential/CredentialCacheManager.java: ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.credential; + +import com.github.benmanes.caffeine.cache.Cache; +import com.github.benmanes.caffeine.cache.Caffeine; +import com.github.benmanes.caffeine.cache.Expiry; +import java.util.Map; +import java.util.concurrent.TimeUnit; +import java.util.function.Function; +import org.apache.gravitino.catalog.CatalogManager; +import org.checkerframework.checker.index.qual.NonNegative; +import org.checkerframework.checker.nullness.qual.NonNull; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class CredentialCacheManager<T> { + private static final Logger LOG = LoggerFactory.getLogger(CatalogManager.class); + + // Calculates the credential expire time in the cache. + static class CredentialExpireTimeCaculator<T> implements Expiry<T, Credential> { + + private long credentialMaxCacheTimeInMs = 0; + + public CredentialExpireTimeCaculator(long credentialMaxCacheTimeInMs) { + this.credentialMaxCacheTimeInMs = credentialMaxCacheTimeInMs; + } + + // Set expire time after add a credential in the cache. + @Override + public long expireAfterCreate( + @NonNull T key, @NonNull Credential credential, long currentTime) { Review Comment: removed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
