FANNG1 commented on code in PR #5995:
URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897884068
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/credential/CredentialConstants.java:
##########
@@ -22,6 +22,8 @@
public class CredentialConstants {
public static final String CREDENTIAL_PROVIDER_TYPE =
"credential-provider-type";
public static final String CREDENTIAL_PROVIDERS = "credential-providers";
+ public static final String CREDENTIAL_CACHE_EXPIRE_IN_SECS =
"credential-cache-expire-in-secs";
Review Comment:
use `credential-cache-expire-ratio`
##########
core/src/main/java/org/apache/gravitino/credential/CredentialCache.java:
##########
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.credential;
+
+import com.github.benmanes.caffeine.cache.Cache;
+import com.github.benmanes.caffeine.cache.Caffeine;
+import com.github.benmanes.caffeine.cache.Expiry;
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+import java.util.function.Function;
+import org.apache.gravitino.credential.config.CredentialConfig;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class CredentialCache<T> implements Closeable {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(CredentialCache.class);
+
+ // Calculates the credential expire time in the cache.
+ static class CredentialExpireTimeCalculator<T> implements Expiry<T,
Credential> {
+
+ private long credentialCacheExpireTimeInMs;
+
+ public CredentialExpireTimeCalculator(long
credentialCacheExpireTimeInSecs) {
+ this.credentialCacheExpireTimeInMs = credentialCacheExpireTimeInSecs *
1000;
+ }
+
+ // Set expire time after add a credential in the cache.
+ @Override
+ public long expireAfterCreate(T key, Credential credential, long
currentTime) {
+ long credentialExpireTime = credential.expireTimeInMs();
+ long timeToExpire = credentialExpireTime - System.currentTimeMillis();
+ if (timeToExpire <= 0) {
+ return 0;
+ }
+
+ long idealExpireTime = Math.min(timeToExpire / 2,
credentialCacheExpireTimeInMs);
+ return TimeUnit.MILLISECONDS.toNanos(idealExpireTime);
+ }
+
+ // Not change expire time after update credential, this should not happen.
+ @Override
+ public long expireAfterUpdate(T key, Credential value, long currentTime,
long currentDuration) {
+ return currentDuration;
+ }
+
+ // Not change expire time after read credential.
+ @Override
+ public long expireAfterRead(T key, Credential value, long currentTime,
long currentDuration) {
+ return currentDuration;
+ }
+ }
+
+ private Cache<T, Credential> credentialCache;
+
+ public void initialize(Map<String, String> catalogProperties) {
+ CredentialConfig credentialConfig = new
CredentialConfig(catalogProperties);
+ long cache_size =
credentialConfig.get(CredentialConfig.CREDENTIAL_CACHE_MAZ_SIZE);
+ long cache_expire_time =
credentialConfig.get(CredentialConfig.CREDENTIAL_CACHE_EXPIRE_IN_SECS);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
