FANNG1 commented on code in PR #5995:
URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897814886
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/credential/CredentialConstants.java:
##########
@@ -22,6 +22,8 @@
public class CredentialConstants {
public static final String CREDENTIAL_PROVIDER_TYPE =
"credential-provider-type";
public static final String CREDENTIAL_PROVIDERS = "credential-providers";
+ public static final String CREDENTIAL_CACHE_EXPIRE_IN_SECS =
"credential-cache-expire-in-secs";
Review Comment:
I don't think we should refresh tokens periodic, the ideal implement may
prefetch credentials according to the access rate of the credential, but this
make cache complicated, I prefer to optimize it latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
