FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897933562
########## core/src/main/java/org/apache/gravitino/credential/CredentialCache.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.credential; + +import com.github.benmanes.caffeine.cache.Cache; +import com.github.benmanes.caffeine.cache.Caffeine; +import com.github.benmanes.caffeine.cache.Expiry; +import java.io.Closeable; +import java.io.IOException; +import java.util.Map; +import java.util.concurrent.TimeUnit; +import java.util.function.Function; +import org.apache.gravitino.credential.config.CredentialConfig; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class CredentialCache<T> implements Closeable { + + private static final Logger LOG = LoggerFactory.getLogger(CredentialCache.class); + + // Calculates the credential expire time in the cache. + static class CredentialExpireTimeCalculator<T> implements Expiry<T, Credential> { + + private double credentialCacheExpireRatio; + + public CredentialExpireTimeCalculator(double credentialCacheExpireRatio) { + this.credentialCacheExpireRatio = credentialCacheExpireRatio; + } + + // Set expire time after add a credential in the cache. + @Override + public long expireAfterCreate(T key, Credential credential, long currentTime) { Review Comment: According the API it's nanosecond. `currentTime – the current time, in nanoseconds` The value of currentTime is odd, and according to the API, seems we should calculate the time by ourself. ``` Note: The currentTime is supplied by the configured Ticker and by default does not relate to system or wall-clock time. When calculating the duration based on a timestamp, the current time should be obtained independently. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
