FANNG1 commented on code in PR #5974:
URL: https://github.com/apache/gravitino/pull/5974#discussion_r1907220778
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##########
@@ -91,6 +100,14 @@ public class GravitinoVirtualFileSystem extends FileSystem {
private static final String SLASH = "/";
private final Map<String, FileSystemProvider> fileSystemProvidersMap =
Maps.newHashMap();
+ private static final Set<String> CATALOG_NECESSARY_PROPERTIES_TO_KEEP =
+ Sets.newHashSet(
+ OSSProperties.GRAVITINO_OSS_ENDPOINT,
Review Comment:
if user doesn't specify S3 endpoint, I doubt whether it could works without
region. For OSS, seems doesn't need region because OSS endpoint is required.
BTW there are duplicated key in the SET.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
