FANNG1 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1907289683
########## catalogs/hadoop-common/src/main/java/org/apache/gravitino/catalog/hadoop/fs/CredentialUtils.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.catalog.hadoop.fs; + +import java.util.Map; + +/** Utility class for Gravitino Virtual File System. */ +public class CredentialUtils { + + /** + * Check if Gravitino credential vending is enabled. + * + * @param config The configuration for Gravitino Virtual File System. + * @return true if Gravitino credential vending is enabled, false otherwise. + */ + public static boolean enableGravitinoCredentialVending(Map<String, String> config) { Review Comment: The name is little odd, what you want to check is it happens in Gravitino server side or fileset client side, but from the name, it may happen on both side. ########## clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/DefaultGravitinoFileSystemCredentialsProvider.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.filesystem.hadoop; + +import com.google.common.base.Preconditions; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.catalog.hadoop.fs.GravitinoFileSystemCredentialsProvider; +import org.apache.gravitino.client.GravitinoClient; +import org.apache.gravitino.credential.Credential; +import org.apache.gravitino.file.Fileset; +import org.apache.gravitino.file.FilesetCatalog; +import org.apache.hadoop.conf.Configuration; + +/** + * Default implementation of {@link GravitinoFileSystemCredentialsProvider} which provides + * credentials for Gravitino Virtual File System. + */ +public class DefaultGravitinoFileSystemCredentialsProvider + implements GravitinoFileSystemCredentialsProvider { + + private Configuration configuration; + + private static final Pattern IDENTIFIER_PATTERN = + Pattern.compile("^(?:gvfs://fileset)?/([^/]+)/([^/]+)/([^/]+)(?>/[^/]+)*/?$"); + + @Override + public void setConf(Configuration configuration) { + this.configuration = configuration; + } + + @Override + public Configuration getConf() { + return configuration; + } + + @Override + public Credential[] getCredentials() { + String virtualPath = configuration.get(GVFS_PATH); Review Comment: How about passing fileset NameIdentifier directly? ########## bundles/azure/src/main/java/org/apache/gravitino/abs/fs/AzureFileSystemProvider.java: ########## @@ -58,12 +64,42 @@ public FileSystem getFileSystem(@Nonnull Path path, @Nonnull Map<String, String> config.get(AzureProperties.GRAVITINO_AZURE_STORAGE_ACCOUNT_KEY)); } - if (!config.containsKey(ABFS_IMPL_KEY)) { + if (!hadoopConfMap.containsKey(ABFS_IMPL_KEY)) { configuration.set(ABFS_IMPL_KEY, ABFS_IMPL); } hadoopConfMap.forEach(configuration::set); + if (enableGravitinoCredentialVending(hadoopConfMap)) { + try { + AzureSasCredentialsProvider azureSasCredentialsProvider = new AzureSasCredentialsProvider(); Review Comment: This seems hacky and hard to understand ``` AzureSasCredentialsProvider azureSasCredentialsProvider = new AzureSasCredentialsProvider(); azureSasCredentialsProvider.initialize(configuration, null); String sas = azureSasCredentialsProvider.getSASToken(null, null, null, null); if (sas != null) { xx } else {xx} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
