yuqi1129 commented on code in PR #5974:
URL: https://github.com/apache/gravitino/pull/5974#discussion_r1907230712


##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##########
@@ -360,6 +266,7 @@ private FilesetContextPair getFilesetContext(Path 
virtualPath, FilesetDataOperat
     FilesetCatalog filesetCatalog =
         catalogCache.get(
             catalogIdent, ident -> 
client.loadCatalog(catalogIdent.name()).asFilesetCatalog());
+    Catalog catalog = (Catalog) filesetCatalog;

Review Comment:
   filesetCatalog is an instance of  interface `FilesetCatalog`  and what we 
need is interface `Catalog` to get its properties, please see L308~L313



##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##########
@@ -383,7 +290,7 @@ private FilesetContextPair getFilesetContext(Path 
virtualPath, FilesetDataOperat
         StringUtils.isNotBlank(scheme), "Scheme of the actual file location 
cannot be null.");
     FileSystem fs =
         internalFileSystemCache.get(
-            scheme,
+            identifier,
             str -> {

Review Comment:
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to