FANNG1 commented on PR #5974:
URL: https://github.com/apache/gravitino/pull/5974#issuecomment-2579122996

   Is changing all filesystem provider a big problems? I think it's necessary 
and clear. Take `S3FileSystemProvider` for example
   
   New implement
   ```
       Map<String, String>  getCredentialConfig(Credential[] credentials) {
            return ImmutableMap.of(Constants.AWS_CREDENTIALS_PROVIDER, 
S3CredentialsProvider.class.getCanonicalName())
      }
   ```
   
   Current implement
   ```
       if (enableGravitinoCredentialVending(config)) {
         configuration.set(
             Constants.AWS_CREDENTIALS_PROVIDER, 
S3CredentialsProvider.class.getCanonicalName());
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to