yuqi1129 commented on code in PR #5974:
URL: https://github.com/apache/gravitino/pull/5974#discussion_r1907425506
##########
bundles/azure/src/main/java/org/apache/gravitino/abs/fs/AzureFileSystemProvider.java:
##########
@@ -58,12 +64,42 @@ public FileSystem getFileSystem(@Nonnull Path path,
@Nonnull Map<String, String>
config.get(AzureProperties.GRAVITINO_AZURE_STORAGE_ACCOUNT_KEY));
}
- if (!config.containsKey(ABFS_IMPL_KEY)) {
+ if (!hadoopConfMap.containsKey(ABFS_IMPL_KEY)) {
configuration.set(ABFS_IMPL_KEY, ABFS_IMPL);
}
hadoopConfMap.forEach(configuration::set);
+ if (enableGravitinoCredentialVending(hadoopConfMap)) {
+ try {
+ AzureSasCredentialsProvider azureSasCredentialsProvider = new
AzureSasCredentialsProvider();
Review Comment:
I don't think using `GravitinoFileSystemCredentialsProvider` to get
Gravitino credentails directly in this class is also a good solution to this
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
