diqiu50 commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1986554343
##########
clients/filesystem-fuse/src/main.rs:
##########
@@ -193,6 +213,33 @@ fn main() -> Result<(), i32> {
path.to_string_lossy().to_string()
};
+ if env::var("RUST_LOG").is_ok() {
+ init_tracing_subscriber(LevelFilter::INFO, "");
+ } else {
+ // if debug > 0, it means that we needs fuse_debug.
+ app_config.fuse.fuse_debug = debug > 0 ||
app_config.fuse.fuse_debug;
+ match debug {
+ 0 => {
+ init_tracing_subscriber(LevelFilter::INFO, "");
Review Comment:
What needs to be done here:
1. RUST_LOG should control the global logging behavior. We should
not override RUST_LOG.
2. When the parameter debug != 0:
• If RUST_LOG is set, use its value and append
gvfs_fuse::fuse_api_handle_debug=debug without overriding RUST_LOG.
• Example: If RUST_LOG=trace, keep the trace level and just
enable FuseApiHandleDebug. If RUST_LOG=info, set
gvfs_fuse::fuse_api_handle_debug=debug along with the original RUST_LOG
setting, ensuring that FuseApiHandleDebug is enabled.
This ensures that RUST_LOG’s original behavior is preserved while
dynamically enabling FuseApiHandleDebug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
