unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1992580732


##########
clients/filesystem-fuse/src/main.rs:
##########
@@ -193,6 +213,33 @@ fn main() -> Result<(), i32> {
                 path.to_string_lossy().to_string()
             };
 
+            if env::var("RUST_LOG").is_ok() {
+                init_tracing_subscriber(LevelFilter::INFO, "");
+            } else {
+                // if debug > 0, it means that we needs fuse_debug.
+                app_config.fuse.fuse_debug = debug > 0 || 
app_config.fuse.fuse_debug;
+                match debug {
+                    0 => {
+                        init_tracing_subscriber(LevelFilter::INFO, "");

Review Comment:
   I want to list some examples to make sure my understanding is correct:
   
   1. When `debug == 0` t, we use value of `RUST_LOG` as directives, the actual 
effect should be RUST_LOG="<original_rust_log_value>".
   2.  when `debug != 0`, we particularly we need to append 
`gvfs_fuse::fuse_api_handle_debug=debug` to the value of `RUST_LOG`, the actual 
effect should be 
`RUST_LOG="<original_rust_log_value>,gvfs_fuse::fuse_api_handle_debug=debug"`. 
This make sure that no matter which level is set by `RUST_LOG` for `gvfs_fuse`, 
`gvfs_fuse::fuse_api_handle_debug` still has debug level.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to