unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1990391628
##########
clients/filesystem-fuse/src/main.rs:
##########
@@ -193,6 +213,33 @@ fn main() -> Result<(), i32> {
path.to_string_lossy().to_string()
};
+ if env::var("RUST_LOG").is_ok() {
+ init_tracing_subscriber(LevelFilter::INFO, "");
+ } else {
+ // if debug > 0, it means that we needs fuse_debug.
+ app_config.fuse.fuse_debug = debug > 0 ||
app_config.fuse.fuse_debug;
+ match debug {
+ 0 => {
+ init_tracing_subscriber(LevelFilter::INFO, "");
Review Comment:
@diqiu50
I have a question:
1. Does your statements implies that:
- if `debug == 0`:
- use `RUST_LOG`'s value as directives.
- if `debug != 0`:
- if `RUST_LOG` has value, then the directive becomes:
`<RUST_LOG_value>,gvfs_fuse::fuse_api_handle_debug=debug` ?
- if `RUST_LOG` is not set, we simply set directives as
`gvfs_fuse::fuse_api_handle_debug=debug` ?
What I not quite sure is:
> 2. When the parameter debug != 0:
• If RUST_LOG is set, use its value and append
gvfs_fuse::fuse_api_handle_debug=debug without overriding RUST_LOG.
Does this means that if `debug != 0`, whatever RUST_LOG value is, we just
set `gvfs_fuse::fuse_api_handle_debug` as debug level ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
