mchades commented on code in PR #7335:
URL: https://github.com/apache/gravitino/pull/7335#discussion_r2131674319
##########
catalogs/catalog-hadoop/src/test/java/org/apache/gravitino/catalog/hadoop/TestHadoopCatalogOperations.java:
##########
@@ -610,52 +610,59 @@ public void testAlterSchema() throws IOException {
@Test
public void testDropSchema() throws IOException {
- String name = "schema20";
- String comment = "comment20";
- String catalogPath = TEST_ROOT_PATH + "/" + "catalog20";
- Schema schema = createSchema(name, comment, catalogPath, null);
- Assertions.assertEquals(name, schema.name());
- NameIdentifier id = NameIdentifierUtil.ofSchema("m1", "c1", name);
+ final long testId = 20L;
+ final String schemaName = "schema" + testId;
+ final String comment = "comment" + testId;
+ final String catalogPath = TEST_ROOT_PATH + "/" + "catalog" + testId;
+
+ stubSchema(testId);
+ Schema schema = createSchema(schemaName, comment, catalogPath, null);
Review Comment:
how about moving the `stubSchema` call into `createSchema` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
