yunchipang commented on code in PR #7335:
URL: https://github.com/apache/gravitino/pull/7335#discussion_r2132642160
##########
catalogs/catalog-hadoop/src/test/java/org/apache/gravitino/catalog/hadoop/TestHadoopCatalogOperations.java:
##########
@@ -980,19 +1006,16 @@ public void testListFilesetFilesWithFSOpsDisabled()
throws Exception {
@Test
public void testListFilesetFilesWithNonExistentPath() throws IOException {
- String schemaName = "schema32";
- String comment = "comment32";
- String filesetName = "fileset32";
- String schemaPath = TEST_ROOT_PATH + "/" + schemaName;
+ final long testId = 32L;
+ final String nonExistentSubPath = "/non_existent_file.txt";
- createSchema(schemaName, comment, null, schemaPath);
- createFileset(filesetName, schemaName, comment, Fileset.Type.MANAGED,
null, null);
+ Schema schema = createSchema(testId);
+ Fileset fileset = createFileset(testId);
+ final NameIdentifier filesetIdent =
+ NameIdentifier.of("m1", "c1", schema.name(), fileset.name());
Review Comment:
@mchades I've overloaded `createSchema` and `createFileset` to take only a
`testId` and stub the schema inside `createSchema`. The change is only applied
to `testListFilesetFilesWithNonExistentPath` for now. Do you think this design
is doable? Does this approach seem reasonable, or does the extra overload
introduce too much complexity? Also, would switching to an `idGenerator`
instead of manually assigning `testId` be a better option?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
