mchades commented on code in PR #7335:
URL: https://github.com/apache/gravitino/pull/7335#discussion_r2133820815
##########
catalogs/catalog-hadoop/src/test/java/org/apache/gravitino/catalog/hadoop/TestHadoopCatalogOperations.java:
##########
@@ -980,19 +1006,16 @@ public void testListFilesetFilesWithFSOpsDisabled()
throws Exception {
@Test
public void testListFilesetFilesWithNonExistentPath() throws IOException {
- String schemaName = "schema32";
- String comment = "comment32";
- String filesetName = "fileset32";
- String schemaPath = TEST_ROOT_PATH + "/" + schemaName;
+ final long testId = 32L;
+ final String nonExistentSubPath = "/non_existent_file.txt";
- createSchema(schemaName, comment, null, schemaPath);
- createFileset(filesetName, schemaName, comment, Fileset.Type.MANAGED,
null, null);
+ Schema schema = createSchema(testId);
+ Fileset fileset = createFileset(testId);
+ final NameIdentifier filesetIdent =
+ NameIdentifier.of("m1", "c1", schema.name(), fileset.name());
Review Comment:
The primary purpose of this PR is to enable developers to write unit tests
more easily by automatically generating IDs, allowing them to focus on the test
logic rather than managing IDs manually. You can consider using the
`idGenerator` if it achieves this goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
