jerryshao commented on code in PR #8131:
URL: https://github.com/apache/gravitino/pull/8131#discussion_r2281150552
##########
common/src/main/java/org/apache/gravitino/dto/tag/TagDTO.java:
##########
@@ -80,15 +80,21 @@ public boolean equals(Object o) {
}
TagDTO tagDTO = (TagDTO) o;
+
+ boolean thisInherited = this.inherited.isPresent() &&
this.inherited.orElse(false);
+ boolean tagDtoInherited = tagDTO.inherited.isPresent() &&
tagDTO.inherited.orElse(false);
Review Comment:
Inherited can be "true", "false", and "null" by design. This changes mix the
"false" and "null" together, which is not correct. Also I delibrately not add
this field into "hashcode" and "equals" calculation, because this is not a
property of the tag, this is calculated in runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
