justinmclean commented on code in PR #8131:
URL: https://github.com/apache/gravitino/pull/8131#discussion_r2282366856
##########
common/src/main/java/org/apache/gravitino/dto/tag/TagDTO.java:
##########
@@ -80,15 +80,21 @@ public boolean equals(Object o) {
}
TagDTO tagDTO = (TagDTO) o;
+
+ boolean thisInherited = this.inherited.isPresent() &&
this.inherited.orElse(false);
+ boolean tagDtoInherited = tagDTO.inherited.isPresent() &&
tagDTO.inherited.orElse(false);
Review Comment:
The original documentation was what I believed to be the intention, which is
why I raised this as an issue.
##########
common/src/main/java/org/apache/gravitino/dto/tag/TagDTO.java:
##########
@@ -80,15 +80,21 @@ public boolean equals(Object o) {
}
TagDTO tagDTO = (TagDTO) o;
+
+ boolean thisInherited = this.inherited.isPresent() &&
this.inherited.orElse(false);
+ boolean tagDtoInherited = tagDTO.inherited.isPresent() &&
tagDTO.inherited.orElse(false);
Review Comment:
The original documentation was what I believed to be the intention, which is
in part why I raised this as an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
