justinmclean commented on code in PR #8131:
URL: https://github.com/apache/gravitino/pull/8131#discussion_r2281237310
##########
common/src/main/java/org/apache/gravitino/dto/tag/TagDTO.java:
##########
@@ -80,15 +80,21 @@ public boolean equals(Object o) {
}
TagDTO tagDTO = (TagDTO) o;
+
+ boolean thisInherited = this.inherited.isPresent() &&
this.inherited.orElse(false);
+ boolean tagDtoInherited = tagDTO.inherited.isPresent() &&
tagDTO.inherited.orElse(false);
Review Comment:
I noticed in another PR (#7933) that the documentation has changed from:
"Same tag can be associated to both parent and child metadata objects. When
you list the associated tags of a child metadata object, this tag will be
included twice in the result list with different `inherited` values."
To:
"Same tag can be associated to both parent and child metadata objects. But
when you list the associated tags of a child metadata object, this tag will be
included only once in the result list with `inherited` value `false`."
Were the tests/code updated to reflect this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
