mchades commented on code in PR #9237:
URL: https://github.com/apache/gravitino/pull/9237#discussion_r2558424868
##########
bundles/azure/src/main/java/org/apache/gravitino/abs/credential/ADLSTokenProvider.java:
##########
@@ -68,70 +48,30 @@ public String credentialType() {
return ADLSTokenCredential.ADLS_TOKEN_CREDENTIAL_TYPE;
}
+ @Override
+ public String getGeneratorClassName() {
+ return "org.apache.gravitino.abs.credential.AzureTokenGenerator";
+ }
+
@Override
public Credential getCredential(CredentialContext context) {
if (!(context instanceof PathBasedCredentialContext)) {
return null;
}
Review Comment:
That's a wrong suggestion. Line 59 already returns null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
