FANNG1 commented on code in PR #9237:
URL: https://github.com/apache/gravitino/pull/9237#discussion_r2559430633
##########
common/src/main/java/org/apache/gravitino/credential/CredentialProvider.java:
##########
@@ -45,12 +49,24 @@ public interface CredentialProvider extends Closeable {
String credentialType();
/**
- * Obtains a credential based on the provided context information.
+ * Gets a credential based on the provided context information.
*
* @param context A context object providing necessary information for
retrieving credentials.
* @return A Credential object containing the authentication information
needed to access a system
* or resource. Null will be returned if no credential is available.
*/
@Nullable
Credential getCredential(CredentialContext context);
+
+ /**
+ * Returns the fully qualified class name of the {@link CredentialGenerator}
implementation. This
+ * generator will be loaded via reflection to perform the actual credential
creation.
+ *
+ * @return The class name of the credential generator.
+ * @throws UnsupportedOperationException if the provider does not use a
generator.
+ */
+ default String getGeneratorClassName() {
Review Comment:
any reason to place this class to `CredentialProvider` not
`CredentialProviderDelegator `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
