FANNG1 commented on code in PR #9237: URL: https://github.com/apache/gravitino/pull/9237#discussion_r2559458679
########## common/src/main/java/org/apache/gravitino/credential/CredentialGenerator.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.credential; + +import java.util.Map; + +/** + * An interface for generating credentials. Implementations of this interface will contain the + * actual logic for creating credentials and may have heavy dependencies. They are intended to be + * loaded via reflection by a {@link CredentialProvider} to avoid classpath issues during service + * loading. + * + * @param <T> The type of credential this generator produces. + */ +@FunctionalInterface +public interface CredentialGenerator<T extends Credential> { Review Comment: How about add init and close method to CredentialGenerator to avoid create resources in every call like sts client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
