mchades commented on code in PR #9502:
URL: https://github.com/apache/gravitino/pull/9502#discussion_r2650902946
##########
catalogs/catalog-fileset/src/main/java/org/apache/gravitino/catalog/fileset/FilesetCatalogCapability.java:
##########
@@ -25,7 +25,8 @@
public class FilesetCatalogCapability implements Capability {
@Override
public CapabilityResult managedStorage(Scope scope) {
- if (Objects.requireNonNull(scope) == Scope.SCHEMA) {
+ if (Objects.requireNonNull(scope) == Scope.CATALOG
Review Comment:
> ManagedStorage means the metadata is stored in Gravitino, Gravitino is
responsible to the lifecycle of the metadata.
Yes, this is a correct explanation of the original intention of
`ManagedStorage`. However, the scope here actually refers to the type of
metadata. For example, when the scope is `schema`:
For the Hive Catalog, its schema is all `unsupported ManagedStorage`,
because the schema of Hive also exists in HMS, and Gravitino cannot fully take
charge of its metadata lifecycle (this also applies to relational catalogs
other than lakehouse-generic).
2. For Fileset Catalog, Model Catalog, and Kafka Catalog, their schemas are
created and stored by Gravitino, so their `managedStorage` method should return
`supported`.
When the scope is catalog, the return value of `ManagedStorage` should all
be supported, because all catalog entities are created and stored by Gravitino,
which is why there was no catalog enumeration value in the scope initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
