yuqi1129 commented on code in PR #9502:
URL: https://github.com/apache/gravitino/pull/9502#discussion_r2647440050
##########
core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java:
##########
@@ -738,45 +739,41 @@ public boolean dropCatalog(NameIdentifier ident, boolean
force)
metalakeIdent,
LockType.WRITE,
() -> {
- checkMetalake(metalakeIdent, store);
Review Comment:
This change has the same effect as
https://github.com/apache/gravitino/pull/9563, as `catalogInUse` will also
access and check the existence of Metalake. see:
https://github.com/apache/gravitino/blob/bd41384a6c1b92a96a6aefb6c54c0ffb748a2bff/core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java#L867-L871
The difference is that `checkMetalake` will throw an exception if a metalake
is not in use, and `catalogInUse` will return false.
@mchades please help to verify whether this breaks your initial design
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
